Skip to content

fix: Moved autoplay button before navigation in DOM order for correct…#2868

Merged
balco0110 merged 6 commits intomainfrom
fix/carousel-autoplay-button-reading-order
Apr 24, 2026
Merged

fix: Moved autoplay button before navigation in DOM order for correct…#2868
balco0110 merged 6 commits intomainfrom
fix/carousel-autoplay-button-reading-order

Conversation

@balco0110
Copy link
Copy Markdown
Contributor

@balco0110 balco0110 commented Mar 19, 2026

… screen reader focus sequence

Description:

Closes: #2415

  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: fec234b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@solid-design-system/components Patch
@solid-design-system/styles Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@balco0110 balco0110 moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

🚀 Storybook has been deployed for branch fix_carousel-autoplay-button-reading-order

@tega-ekakitie
Copy link
Copy Markdown

@balco0110 Looks good to me

smfonseca
smfonseca previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@smfonseca smfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok, but would be good to merge this PR and get the new changes into this branch and test again just to be on the safe side.

@smfonseca smfonseca removed their assignment Apr 20, 2026
@balco0110 balco0110 moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Apr 23, 2026
@mariohamann mariohamann moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Apr 23, 2026
@balco0110 balco0110 force-pushed the fix/carousel-autoplay-button-reading-order branch from 7daf35e to 27ab7e4 Compare April 23, 2026 08:30
@balco0110 balco0110 merged commit 6e80707 into main Apr 24, 2026
19 checks passed
@balco0110 balco0110 deleted the fix/carousel-autoplay-button-reading-order branch April 24, 2026 09:49
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: 🤔 Rotation control button is the first element in the screen reader reading order

7 participants